Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build!: Set Node v12 to minimum supported version & Upgrade TypeScript #1392

Merged
merged 8 commits into from Apr 20, 2022
Merged

build!: Set Node v12 to minimum supported version & Upgrade TypeScript #1392

merged 8 commits into from Apr 20, 2022

Conversation

danielbankhead
Copy link
Member

Drops Node 10 support, which has been EOL for about 1 year. 🦕

See: Google Cloud moves Cloud Client Libraries for Node.js support for version 10 to Maintenance

@danielbankhead
build!: Set Node v12 to minimum supported version
fbc5494 
Drops Node 10 support, which has been EOL for about 1 year.
@danielbankhead danielbankhead added priority: p2 Moderately-important priority. Fix may not be included in next release. do not merge Indicates a pull request not ready for merge, due to either quality or timing. semver: major Hint for users that this is an API breaking change. Breaking Change labels Apr 9, 2022
@danielbankhead danielbankhead requested review from a team as code owners April 9, 2022 01:58
@generated-files-bot
Copy link

generated-files-bot bot commented Apr 9, 2022 •
edited

Warning: This pull request is touching the following templated files:

  • .kokoro/continuous/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/browser-test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/continuous/node8/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/common.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/docs.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/lint.cfg - .kokoro files are templated and should be updated in synthtool
  • .kokoro/presubmit/node10/test.cfg - .kokoro files are templated and should be updated in synthtool
  • .github/workflows/ci.yaml - .github/workflows/ci.yaml (GitHub Actions) should be updated in synthtool

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 9, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Apr 9, 2022
@danielbankhead danielbankhead added the eol End of life. Deprecating support for a previous version. label Apr 9, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Apr 14, 2022
@danielbankhead danielbankhead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 14, 2022
@danielbankhead danielbankhead changed the title build!: Set Node v12 to minimum supported version build!: Set Node v12 to minimum supported version & Upgrade TypeScript Apr 14, 2022
@sofisl
Copy link
Contributor

sofisl commented Apr 18, 2022

LGTM. We'll need to manually remove the Node 10 test requirement to merge this, I can do it once we're ready. But I'd like for @bcoe to review first.

@bcoe bcoe merged commit b7bcedb into main Apr 20, 2022
@bcoe bcoe deleted the drop-node-10 branch April 20, 2022 15:39
@release-please release-please bot mentioned this pull request Apr 20, 2022
Merged
sai-sunder-s pushed a commit to sai-sunder-s/google-auth-library-nodejs that referenced this pull request Aug 24, 2022
@gcf-owl-bot @SurferJeffAtGoogle
chore(deps): update actions/checkout action to v3 (googleapis#1392) (g…
b482544 
…oogleapis#1389)

Co-authored-by: Jeffrey Rennie <rennie@google.com>
Source-Link: googleapis/synthtool@9368bc7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:f74e740638e66be7ced1540626217dbb72980eb73885b2339a70592f38c9ff2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoe bcoe bcoe approved these changes

@sofisl sofisl sofisl approved these changes

Assignees

@bcoe bcoe

Labels
Breaking Change eol End of life. Deprecating support for a previous version. priority: p2 Moderately-important priority. Fix may not be included in next release. semver: major Hint for users that this is an API breaking change. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danielbankhead @sofisl @bcoe