Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make transporter attribute type more generic #1406

Merged
merged 8 commits into from
Jul 10, 2023
Merged

feat!: make transporter attribute type more generic #1406

merged 8 commits into from
Jul 10, 2023

Conversation

forty
Copy link
Contributor

@forty forty commented May 5, 2022

Hello,

currently transporter attributes are inferred or explicitly typed as DefaultTransporter, which is too bad since the Transporter type exist I assume to make room for custom implementation (which I use, but currently I have to either extends DefaultTransporter, or force TS to ignore the typing)

@forty forty requested review from a team as code owners May 5, 2022 17:21
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 5, 2022
danielbankhead
danielbankhead approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@danielbankhead
Copy link
Member

As a note - I think this is a worth-while change, but would be backwards-incompatible as Transporter does not have static USER_AGENT and the configure method (which are public for consumers). Marking this PR for a future major release.

@danielbankhead danielbankhead added do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version labels Jun 2, 2022
@danielbankhead danielbankhead changed the title feat: make tranporter attribute type more generic feat!: make transporter attribute type more generic Aug 19, 2022
@danielbankhead danielbankhead mentioned this pull request Nov 29, 2022
Closed
@danielbankhead danielbankhead removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 5, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 10, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Jul 10, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 10, 2023
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jul 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 10, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 10, 2023
@danielbankhead danielbankhead merged commit dfac525 into googleapis:main Jul 10, 2023
15 checks passed
@release-please release-please bot mentioned this pull request Jul 10, 2023
Merged
@danielbankhead danielbankhead mentioned this pull request Aug 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@forty @danielbankhead @yoshi-kokoro @bcoe @sofisl