Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Instantiating OAuth2Client with Credentials #1652

Merged
merged 4 commits into from
Oct 2, 2023
Merged

feat: Support Instantiating OAuth2Client with Credentials #1652

merged 4 commits into from
Oct 2, 2023

Conversation

danielbankhead
Copy link
Member

This PR solves 2 problems:

  • Allows customers to use an OAuth2Client with only an access_token
  • Allows customers to quickly 'rehydrate' an OAuth2Client a little easier and potentially remove a network call as we can reuse an access token if it hasn't expired.

Fixes #677 馃

@danielbankhead danielbankhead requested review from a team as code owners September 27, 2023 22:16
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 27, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 27, 2023
View reviewed changes
test/test.oauth2.ts Dismissed Show resolved Hide resolved
This was referenced Sep 29, 2023
Closed
Closed
@danielbankhead danielbankhead merged commit 4339d64 into main Oct 2, 2023
18 checks passed
@danielbankhead danielbankhead deleted the access-token-support branch October 2, 2023 23:14
@release-please release-please bot mentioned this pull request Oct 2, 2023
Merged
@alvarowolfx alvarowolfx mentioned this pull request Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeitzman aeitzman aeitzman approved these changes

Assignees
No one assigned
Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow providing a token argument
2 participants
@danielbankhead @aeitzman