Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement GCE residency detection on Windows #470

Closed
bshaffer opened this issue Aug 22, 2023 · 0 comments · Fixed by #553
Closed

feat: implement GCE residency detection on Windows #470

bshaffer opened this issue Aug 22, 2023 · 0 comments · Fixed by #553
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

bshaffer commented Aug 22, 2023

See #469

Implement detection of Windows machines as a fallback when the metadata server ping fails. This is already implemented for Linux, but is currently bypassed for Windows.

if (PHP_OS === 'Windows') {
// @TODO: implement GCE residency detection on Windows
return false;
}

Implementation details can be found at go/auth-library-noping, or by discussing with @TimurSadykov or @sai-sunder-s

@bshaffer bshaffer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants