Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default file caching #498

Open
bshaffer opened this issue Nov 28, 2023 · 0 comments
Open

Add default file caching #498

bshaffer opened this issue Nov 28, 2023 · 0 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

bshaffer commented Nov 28, 2023

For any company running at scale, a default file cache is pretty much a requirement to ensure that the client libraries and auth library function in a performant way. Creating a file cache which works out of the box (and by default) would be a huge help to our customers which are running these libraries at scale.

Rationale: customers have had to create wrappers which implement their custom caching, and this has caused headache, when the configuration for these caches should be intuitive enough and easy enough to implement that they can happen out of the box without handholding or wrapper classes.

For examples of existing FileCache, see php-cache/filesystem-adapter, which uses the FilesystemCachePool, and is implemented in the BaseTest class of our Apiary client library.

  • Follow the PHP-FIG PSR-6 caching interfaces
  • Make sure that the getCacheKey methods are unique and safe
  • Verify with testing and benchmarks that a PHP application receiving multiple requests and handling multiple processes will handle them in a scalable way (e.g Metadata Server credentials, JWT credentials, etc).
@bshaffer bshaffer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Dec 21, 2023
@Hectorhammett Hectorhammett self-assigned this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants