Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update automatic retries and Implement Retryable interface for token endpoint requests #980

Closed
TimurSadykov opened this issue Feb 15, 2022 · 2 comments
Closed

Update automatic retries and Implement Retryable interface for token endpoint requests #980

TimurSadykov opened this issue Feb 15, 2022 · 2 comments
Assignees
@clundin25
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@TimurSadykov
Copy link
Member

Current implementation of automatic retries to token endpoint does not follow Auth service guidelines. In addition, clients do not have a good way to distinguish retryable errors and implement custom retry strategies. Sometimes this causes infinite retries like here: https://github.com/nwbirnie/gapic-oauth-invalid-hangs

More details in the doc: go/auth-correct-retry

Please prioritize the fix if infinite retry like for Java is repro here as well.
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 16, 2022
@arithmetic1728 arithmetic1728 mentioned this issue Mar 1, 2022
Open
@arithmetic1728 arithmetic1728 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 30, 2022
@arithmetic1728 arithmetic1728 added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triage me I really want to be triaged. labels Mar 30, 2022
@arithmetic1728
Copy link
Contributor

assigning to Timur to prioritize the work

@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Mar 30, 2022
@parthea parthea mentioned this issue Apr 10, 2022
Closed
@TimurSadykov TimurSadykov removed their assignment Sep 8, 2022
@clundin25
Copy link
Contributor

#1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@clundin25 clundin25

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TimurSadykov @yoshi-automation @arithmetic1728 @clundin25