Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Upgrade builds to use protobuf-3.11.3 #1230

Closed
coryan opened this issue Feb 1, 2020 · 11 comments
Closed

Upgrade builds to use protobuf-3.11.3 #1230

coryan opened this issue Feb 1, 2020 · 11 comments
Assignees
Labels
external This issue is blocked on a bug with the actual product. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Member

coryan commented Feb 1, 2020

This will be the first version with the fixes for protocolbuffers/protobuf#7076, which we need to compile the latest version of googleapis (via cpp-cmakefiles >= v0.4.1) which contains the support for resource-based routing.

@coryan coryan added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 1, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. label Feb 1, 2020
@coryan coryan added external This issue is blocked on a bug with the actual product. and removed api: spanner Issues related to the googleapis/google-cloud-cpp-spanner API. labels Feb 1, 2020
@coryan
Copy link
Member Author

coryan commented Feb 1, 2020

Blocked on waiting for the Protocol Buffers release.

@devbww
Copy link
Contributor

devbww commented Feb 6, 2020

We now have protobuf-3.11.3, so I'll repurpose this for the upgrade to cpp-cmakefiles v0.4.1.

@devbww devbww self-assigned this Feb 6, 2020
@devbww
Copy link
Contributor

devbww commented Feb 6, 2020

@coryan ... should I upgrade googleapis/cpp-cmakefiles to the latest googleapis/googleapis first?

@coryan
Copy link
Member Author

coryan commented Feb 6, 2020

I do not know. If all the proto changes you need are in 0.4.1, then probably not, because why do more work? Otherwise, then yes, you have to create 0.4.2 or 0.5.0 (I have been increasing the minor number for new libraries, the minor for just tweaks to the protos).

@coryan
Copy link
Member Author

coryan commented Feb 6, 2020

I just remembered something. The Windows+CMake build is still on protobuf-3.11.2, and won't compile with 0.4.1 (or any newer protos).

@devbww
Copy link
Contributor

devbww commented Feb 6, 2020

It appears that everything I need (for #1181) is indeed already in cpp-cmakefiles v0.4.1.

And nothing that anyone else needs has yet landed in googleapis/googleapis.

So, I'll skip the googleapis/googleapis update.

@devbww
Copy link
Contributor

devbww commented Feb 6, 2020

I just remembered something. The Windows+CMake build is still on protobuf-3.11.2, and won't compile with 0.4.1 (or any newer protos).

This is a vcpkg thing? Or, more specifically, what might I be able to do to get Windows+CMake up to protobuf-3.11.3?

@coryan
Copy link
Member Author

coryan commented Feb 6, 2020

I just remembered something. The Windows+CMake build is still on protobuf-3.11.2, and won't compile with 0.4.1 (or any newer protos).

This is a vcpkg thing?

Yes. It should be a matter of hours (or at most days) for microsoft/vcpkg#9889 to be merged though.

Or, more specifically, what might I be able to do to get Windows+CMake up to protobuf-3.11.3?

Wait for that PR to merge or the overlay crazy dance.

@devbww
Copy link
Contributor

devbww commented Feb 6, 2020

Excellent. I can wait. Thanks.

@devbww
Copy link
Contributor

devbww commented Feb 7, 2020

microsoft/vcpkg#9889 is merged. Yay.

So I'll now move forward on the upgrade to cpp-cmakefiles v0.4.1.

@devbww
Copy link
Contributor

devbww commented Feb 7, 2020

Fixed by #1247 and #1253.

@devbww devbww closed this as completed Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external This issue is blocked on a bug with the actual product. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants