Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: TestOCStats_SessionPool failed #3000

Closed
flaky-bot bot opened this issue Oct 12, 2020 · 10 comments · Fixed by #3013
Closed

spanner: TestOCStats_SessionPool failed #3000

flaky-bot bot opened this issue Oct 12, 2020 · 10 comments · Fixed by #3013
Assignees
@olavloite
Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Oct 12, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

commit: 93dbeac
buildURL: Build Status, Sponge
status: failed

Test output
oc_test.go:127: Incorrect data: got &{2020-10-12 16:03:07.290190978 +0000 UTC m=+48.061696207 1}, want &{1}
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 12, 2020
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Oct 12, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 12, 2020

commit: 709d6e7
buildURL: Build Status, Sponge
status: failed

Test output
oc_test.go:127: Incorrect data: got &{2020-10-12 18:58:59.268093092 +0000 UTC m=+66.450854082 1}, want &{1}

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 12, 2020

commit: 3a12a18
buildURL: Build Status, Sponge
status: failed

Test output
oc_test.go:127: Incorrect data: got &{2020-10-12 20:57:06.221681578 +0000 UTC m=+89.509410990 1}, want &{1}

@skuruppu skuruppu assigned olavloite and unassigned skuruppu Oct 13, 2020
@skuruppu
Copy link
Contributor

@olavloite if you could also take a look at this one, we'd really appreciate it.

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 13, 2020

commit: 9611fae
buildURL: Build Status, Sponge
status: failed

Test output
    oc_test.go:127: Incorrect data: got &{2020-10-13 14:58:36.002865914 +0000 UTC m=+104.182171843 1}, want &{1}

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 13, 2020

commit: 1d92e20
buildURL: Build Status, Sponge
status: failed

Test output
oc_test.go:127: Incorrect data: got &{2020-10-13 15:30:08.619603301 +0000 UTC m=+74.069308571 1}, want &{1}

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 13, 2020

commit: deaa855
buildURL: Build Status, Sponge
status: failed

Test output
oc_test.go:127: Incorrect data: got &{2020-10-13 21:09:17.716310692 +0000 UTC m=+76.758675707 1}, want &{1}

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 13, 2020

commit: 69ed6f8
buildURL: Build Status, Sponge
status: failed

Test output
    oc_test.go:127: Incorrect data: got &{2020-10-13 22:21:51.232262879 +0000 UTC m=+49.399691269 1}, want &{1}

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 13, 2020

commit: 7df1879
buildURL: Build Status, Sponge
status: failed

Test output
oc_test.go:127: Incorrect data: got &{2020-10-13 23:15:55.808873475 +0000 UTC m=+76.958393604 1}, want &{1}

@flaky-bot
Copy link
Author

flaky-bot bot commented Oct 14, 2020

commit: 3fb19a5
buildURL: Build Status, Sponge
status: failed

Test output
    oc_test.go:127: Incorrect data: got &{2020-10-14 01:10:27.184805636 +0000 UTC m=+50.501501300 1}, want &{1}

@olavloite
Copy link
Contributor

This is caused by the combination of the following two factors:

  1. The test case compares the value of an OC row with the expected value by comparing fmt.Sprintf("%v", row.Data) with a fixed expected value. Data does not implement Stringer, which means that the string will contain the value of each field of the struct.
  2. The OC Data struct was recently changed to include a StartTime field, which means that the output has changed.

olavloite added a commit that referenced this issue Oct 14, 2020
@olavloite
test(spanner): compare data instead of struct
fd33b3b 
Compare the underlying Open Census row data, instead of the entire row
struct, with the expected value. This prevents the comparison from breaking
if new fields are added to the struct.

Fixes #3000
@olavloite olavloite mentioned this issue Oct 14, 2020
Merged
olavloite added a commit that referenced this issue Oct 14, 2020
@olavloite
test(spanner): compare data instead of struct (#3013)
0113f76 
Compare the underlying Open Census row data, instead of the entire row
struct, with the expected value. This prevents the comparison from breaking
if new fields are added to the struct.

Fixes #3000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(spanner): compare data instead of struct googleapis/google-cloud-go
2 participants
@skuruppu @olavloite