feat(pubsublite): set finalizer for PublisherClient #7109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
codyoss
reviewed
Dec 1, 2022
dpcollins-google
approved these changes
Dec 1, 2022
tmdiep
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
🤖 I have created a release *beep* *boop* --- ## [1.5.0](https://togithub.com/googleapis/google-cloud-go/compare/pubsublite/v1.4.1...pubsublite/v1.5.0) (2022-12-01) ### Features * **pubsublite:** Add current state of export subscriptions to API ([2a0b1ae](https://togithub.com/googleapis/google-cloud-go/commit/2a0b1aeb1683222e6aa5c876cb945845c00cef79)) * **pubsublite:** Remove obsolete export subscription statuses field from API ([7231644](https://togithub.com/googleapis/google-cloud-go/commit/7231644e71f05abc864924a0065b9ea22a489180)) * **pubsublite:** Set finalizer for PublisherClient ([#7109](https://togithub.com/googleapis/google-cloud-go/issues/7109)) ([e648bd9](https://togithub.com/googleapis/google-cloud-go/commit/e648bd95ff5b33383440e18245106741292ac97a)) * **pubsublite:** start generating proto stubs ([cf89415](https://togithub.com/googleapis/google-cloud-go/commit/cf894154e451a32b431fef2af3781a0d2d8080ff)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigates
PublisherClient.Stopnot being called when the publisher is no longer used. Users must still callStopto promptly shut down the publisher, as finalizers run after an arbitrary amount of time.