Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud.google.com/go/storage: builds fail on v1.34.0 #8956

Closed
ahimelman opened this issue Nov 1, 2023 · 2 comments
Closed

cloud.google.com/go/storage: builds fail on v1.34.0 #8956

ahimelman opened this issue Nov 1, 2023 · 2 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API.

Comments

@ahimelman
Copy link

Builds are failing for the cloud.google.com/go/storage package after upgrading to 1.34.0: https://github.com/googleapis/google-cloud-go/releases/tag/storage%2Fv1.34.0

example repro:

package main

import (
	"context"
    "cloud.google.com/go/storage"
)

func main() {
	client, err := storage.NewClient(context.Background())
	if err != nil {
		log.Fatal(err)
	}
}

leads to the build failures

# cloud.google.com/go/storage
../../go/pkg/mod/cloud.google.com/go/storage@v1.34.0/bucket.go:1252:4: unknown field TerminalStorageClass in struct literal of type "google.golang.org/api/storage/v1".BucketAutoclass
../../go/pkg/mod/cloud.google.com/go/storage@v1.34.0/bucket.go:1969:3: unknown field TerminalStorageClass in struct literal of type "google.golang.org/api/storage/v1".BucketAutoclass
../../go/pkg/mod/cloud.google.com/go/storage@v1.34.0/bucket.go:1993:27: a.TerminalStorageClass undefined (type *"google.golang.org/api/storage/v1".BucketAutoclass has no field or method TerminalStorageClass)
../../go/pkg/mod/cloud.google.com/go/storage@v1.34.0/bucket.go:2000:40: a.TerminalStorageClassUpdateTime undefined (type *"google.golang.org/api/storage/v1".BucketAutoclass has no field or method TerminalStorageClassUpdateTime)
@ahimelman ahimelman added the triage me I really want to be triaged. label Nov 1, 2023
@noahdietz
Copy link
Contributor

noahdietz commented Nov 1, 2023

The min version of google.golang.org/api used in Storage (v0.132.0) for #8721 is too old. The TerminalStorageClass property was added in v0.142.0.

I updated every version of this dep to the latest in #8959, which should fix this. @cojenco @BrennaEpp @tritone

@noahdietz noahdietz added api: storage Issues related to the Cloud Storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Nov 1, 2023
@noahdietz noahdietz assigned BrennaEpp and unassigned tritone Nov 1, 2023
@noahdietz noahdietz removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Nov 1, 2023
@tritone tritone assigned tritone and unassigned BrennaEpp Nov 1, 2023
@tritone
Copy link
Contributor

tritone commented Nov 1, 2023

Apologies for the disruption, this was due to an outdated dependency. We have cut storage/v1.34.1 which resolves the issue.

@tritone tritone closed this as completed Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

No branches or pull requests

4 participants