Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [edgenetwork] new module for edgenetwork #10136

Merged
merged 9 commits into from Jan 4, 2024
Merged

feat: [edgenetwork] new module for edgenetwork #10136

merged 9 commits into from Jan 4, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Dec 12, 2023 •
edited 

python3.9 generation/new_client/new-client.py generate   
--api_shortname=edgenetwork   
--proto-path=google/cloud/edgenetwork   
--name-pretty="Distributed Cloud Edge Network API"  
--product-docs="https://cloud.google.com/distributed-cloud/edge/latest/docs/overview"   
--api-description="Network management API for Distributed Cloud Edge."

@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Dec 12, 2023 •
edited

Here is the summary of changes.

You are about to add 128 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo suztomo mentioned this pull request Dec 18, 2023
Open
@mpeddada1 mpeddada1 requested a review from a team as a code owner January 3, 2024 14:52
@mpeddada1
Copy link
Contributor Author

The header check is temporarily not required. See #10183

@suztomo
Copy link
Member

suztomo commented Jan 4, 2024

header-check failing due to copyright year 2023. I just removed the required mark.

@mpeddada1 mpeddada1 merged commit e4107b2 into main Jan 4, 2024
32 of 33 checks passed
@mpeddada1 mpeddada1 deleted the new_module_java-edgenetwork_updated branch January 4, 2024 16:41
@release-please release-please bot mentioned this pull request Jan 4, 2024
Merged
@JoeWang1127 JoeWang1127 mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mpeddada1 @suztomo @lqiu96