Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [cloudasset] added new resource references to fields in AnalyzeMoveRequest #10138

Merged
merged 6 commits into from Jan 2, 2024

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Dec 12, 2023

  • Regenerate this pull request now.

docs: updated comments
chore: removed backend configuration from service config

PiperOrigin-RevId: 590982722

Source-Link: googleapis/googleapis@da09f4c

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7dd789a2cad4d544fbb53a15ce59deb467f30b6d
Copy-Tag: eyJwIjoiamF2YS1hc3NldC8uT3dsQm90LnlhbWwiLCJoIjoiN2RkNzg5YTJjYWQ0ZDU0NGZiYjUzYTE1Y2U1OWRlYjQ2N2YzMGI2ZCJ9

BEGIN_NESTED_COMMIT
feat: [cloudasset] added messages ExportAssetsResponse, BatchGetAssetsHistoryResponse
feat: added Asset.access_policy, access_level, service_perimeter, org_policy
feat: added resource definitions to some messages
docs: updated comments
chore: removed backend configuration from service config

PiperOrigin-RevId: 589961470

Source-Link: googleapis/googleapis@02fbe75

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2a25ee3638abdc2ea520c87e1d4c7c53fc624e30
Copy-Tag: eyJwIjoiamF2YS1hc3NldC8uT3dsQm90LnlhbWwiLCJoIjoiMmEyNWVlMzYzOGFiZGMyZWE1MjBjODdlMWQ0YzdjNTNmYzYyNGUzMCJ9
END_NESTED_COMMIT

feat: added Asset.access_policy, access_level, service_perimeter, org_policy
feat: added resource definitions to some messages
docs: updated comments
chore: removed backend configuration from service config

PiperOrigin-RevId: 589961470

Source-Link: googleapis/googleapis@02fbe75

Source-Link: googleapis/googleapis-gen@2a25ee3
Copy-Tag: eyJwIjoiamF2YS1hc3NldC8uT3dsQm90LnlhbWwiLCJoIjoiMmEyNWVlMzYzOGFiZGMyZWE1MjBjODdlMWQ0YzdjNTNmYzYyNGUzMCJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review December 12, 2023 01:19
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 12, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 12, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 12, 2023
docs: updated comments
chore: removed backend configuration from service config

PiperOrigin-RevId: 590982722

Source-Link: googleapis/googleapis@da09f4c

Source-Link: googleapis/googleapis-gen@7dd789a
Copy-Tag: eyJwIjoiamF2YS1hc3NldC8uT3dsQm90LnlhbWwiLCJoIjoiN2RkNzg5YTJjYWQ0ZDU0NGZiYjUzYTE1Y2U1OWRlYjQ2N2YzMGI2ZCJ9
@gcf-owl-bot gcf-owl-bot bot changed the title feat: [cloudasset] added messages ExportAssetsResponse, BatchGetAssetsHistoryResponse feat: [cloudasset] added new resource references to fields in AnalyzeMoveRequest Dec 14, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 14, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 14, 2023
Copy link

snippet-bot bot commented Dec 14, 2023

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@suztomo
Copy link
Member

suztomo commented Jan 2, 2024

@diegomarquezp What needs to happen here?

IT for google/cloud/asset/v1 failing as recent changes in googleapis have not been reflected in google-cloud-java (pending PR: #10138)

@suztomo
Copy link
Member

suztomo commented Jan 2, 2024

Missing dependencies?

Error: 0:006 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project proto-google-cloud-asset-v1p2beta1: Compilation failure: Compilation failure: 
Error: 0:006 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-asset/proto-google-cloud-asset-v1p2beta1/src/main/java/com/google/cloud/asset/v1p2beta1/AssetOrBuilder.java:[292,46] package com.google.identity.accesscontextmanager.v1 does not exist
Error: 0:006 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-asset/proto-google-cloud-asset-v1p2beta1/src/main/java/com/google/cloud/asset/v1p2beta1/AssetOrBuilder.java:[303,46] package com.google.identity.accesscontextmanager.v1 does not exist
Error: 0:006 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-asset/proto-google-cloud-asset-v1p2beta1/src/main/java/com/google/cloud/asset/v1p2beta1/AssetOrBuilder.java:[330,46] package com.google.identity.accesscontextmanager.v1 does not exist
Error: 0:006 [ERROR] /home/runner/work/google-cloud-java/google-cloud-java/java-asset/proto-google-cloud-asset-v1p2beta1/src/main/java/com/google/cloud/asset/v1p2beta1/AssetOrBuilder.java:[341,46] package com.google.identity.accesscontextmanager.v1 does not exist

Why java/com/google/cloud/asset/v1p2beta1/AssetOrBuilder.java is referencing com.google.identity.accesscontextmanager.v1? => I thought they're in different version in the same service. It's fine that they're in different package.

What does the problematic line look like?

  public com.google.identity.accesscontextmanager.v1.AccessPolicy getAccessPolicy() {

Where is com.google.identity.accesscontextmanager.v1? => It's ./java-accesscontextmanager/proto-google-identity-accesscontextmanager-v1/src/main/java/com/google/identity/accesscontextmanager/v1/AccessPolicy.java.

How to reproduce the issue

~/google-cloud-java $ mvn clean compile -pl java-asset/proto-google-cloud-asset-v1p2beta1 -am -DskipTests

...
[INFO] --- maven-compiler-plugin:3.11.0:compile (default-compile) @ proto-google-cloud-asset-v1p2beta1 ---
[INFO] Changes detected - recompiling the module! :source
[INFO] Compiling 38 source files with javac [debug deprecation target 1.8] to target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /Users/suztomo/google-cloud-java/java-asset/proto-google-cloud-asset-v1p2beta1/src/main/java/com/google/cloud/asset/v1p2beta1/Asset.java:[489,53] package com.google.identity.accesscontextmanager.v1 does not exist
[ERROR] /Users/suztomo/google-cloud-java/java-asset/proto-google-cloud-asset-v1p2beta1/src/main/java/com/google/cloud/asset/v1p2beta1/Asset.java:[506,53] package com.google.identity.accesscontextmanager.v1 does not exist

@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 2, 2024 21:04
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 2, 2024
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests passed

Comment on lines +36 to 44
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-orgpolicy-v1</artifactId>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-identity-accesscontextmanager-v1</artifactId>
</dependency>
</dependencies>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memo for myself: The versions are defined in the parent pom.

Screenshot 2024-01-02 at 4 50 54 PM

@suztomo suztomo enabled auto-merge (squash) January 2, 2024 21:52
@suztomo suztomo merged commit 66f99c3 into main Jan 2, 2024
33 checks passed
@suztomo suztomo deleted the owl-bot-copy-java-asset branch January 2, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants