Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on a problematic license #2786

Closed
jinwoo opened this issue Jan 8, 2018 · 2 comments
Closed

Dependency on a problematic license #2786

jinwoo opened this issue Jan 8, 2018 · 2 comments
Assignees

Comments

@jinwoo
Copy link

jinwoo commented Jan 8, 2018

@google-cloud/common-grpc has a transitive dependency, jsonify, whose license is "Public Domain". "Public Domain" is not a valid license for Google.

This issue blocks #2785.

We need to either get an approval for that package or remove the dependency.

The dependency chain is like this:

@google-cloud/common-grpc@0.5.2 -> grpc@1.7.3 -> node-pre-gyp@0.6.39 -> request@2.81.0 -> har-validator@4.2.1 -> ajv@4.11.8 -> json-stable-stringify@1.0.1 -> jsonify@0.0.0
@jinwoo jinwoo changed the title Dependency with a problematic license Dependency on a problematic license Jan 8, 2018
@jinwoo
Copy link
Author

jinwoo commented Jan 8, 2018

I made a PR in the node-pre-gyp package as a resolution to this: mapbox/node-pre-gyp#342

But that makes tests fail with Node 0.10.

@jinwoo
Copy link
Author

jinwoo commented Jan 8, 2018

Closing this because an issue was filed directly under grpc: grpc/grpc-node#145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant