Node 8 deprecation party 🎉 #2972

bcoe · 2020-02-29T00:45:00Z

For reference, here's a PR adding the new gts.

Wave 1: (Day 1)

Wave 2 (Day 1)

Wave 3 (Day 1)

Wave 4 (Day 1)

Wave 5: fair game

Wave 6: fair game once wave 5 is done

Wait for go ahead from @bcoe

Wait for go ahead from Sebastian and Firebase Team

feywind · 2020-02-29T01:02:30Z

Async iterator usage?

zamnuts · 2020-03-03T05:35:40Z

As part of TS 3.7 upgrade: optional chaining, nullish coalescing

http2 now supports ORIGIN frames to enable cross-origin connection reuse, do the GCP servers-side APIs support this optimization?

And for a list of new things, relevant breaking changes or things to watch out for as part of any node 8.x -> 10.x uplift as it relates to googleapis node.js code:

assert interface changes (may inadvertently fail test cases):
- assert.fail only has 1 arg: nodejs/node@70dcacd710
- assert.ifError only allows undefined and null, previously truthy was allowed: nodejs/node@e65a6e81ef
- use native assert.rejects and assert.doesNotReject: nodejs/node@599337f43e
net now does an explicit close after end, if workarounds were implemented, this will reveal potential race conditions under load: nodejs/node@9b7a6914a7
http2 streams fixed the destroy/end bug: stream: fix end-of-stream for HTTP/2 nodejs/node#24926
streams:
- refactor to use stream.pipeline where/if applicable
- if using pause mode, watch for workarounds related to implicit repeat _read calls when using resume and read, this memory bug has been fixed: stream: do not unconditionally call _read() on resume() nodejs/node#26965
if a promise settles multiple times, warns will be present in this case: process: add multipleResolves event nodejs/node#22218

Are we using matrix builds against 8.x and 10.x at the same time? If so, most of this stuff should've already been noticed.

bcoe · 2020-03-03T18:02:41Z

@zamnuts we have had Node 10 in the build matrix for close to a year I think, and I'd bet over 50% of our users are already on Node 10 👍

With regards to improvements, like having optional chaining at our disposal, I think we should use these language features going forward to cleanup our codebases, but a large sweeping refactor shouldn't be part of dropping Node 8 from the testing matrix.

bcoe · 2020-03-03T18:04:59Z

Async iterator usage?

@feywind, @xiaozhenliu-gg5 came up with a design document which should allow us to add async iterators to Node 10, without it being a breaking change, as soon as 8 is dropped.

So, we're going to use async iterators, which I'm very excited about, but we don't need to get this refactor done for dropping Node 8 (I don't believe).

JustinBeckwith · 2020-06-24T04:22:59Z

I think we're ready to call this party a wrap :) Firestore is the only one left, and they're working independently to get things sorted out.

JustinBeckwith added the type: process A process-related concern. May include testing, release, or the like. label Feb 29, 2020

bcoe assigned xiaozhenliu-gg5 and unassigned xiaozhenliu-gg5 Mar 24, 2020

summer-ji-eng mentioned this issue Mar 25, 2020

chore(dep)!: upgrade gts 2.0.0 googleapis/teeny-request#146

Closed

summer-ji-eng mentioned this issue Apr 8, 2020

chore(dep)!: deprecate node 8 googleapis/google-api-nodejs-client#2021

Merged

bcoe mentioned this issue May 12, 2020

switch to es2018 in tsconfig.json once none are supporting Node 8 googleapis/gapic-generator-typescript#479

Closed

JustinBeckwith closed this as completed Jun 24, 2020

JustinBeckwith self-assigned this Feb 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Node 8 deprecation party 🎉 #2972

Node 8 deprecation party 🎉 #2972

bcoe commented Feb 29, 2020 •

edited

feywind commented Feb 29, 2020

zamnuts commented Mar 3, 2020

bcoe commented Mar 3, 2020

bcoe commented Mar 3, 2020

JustinBeckwith commented Jun 24, 2020

Node 8 deprecation party 🎉 #2972

Node 8 deprecation party 🎉 #2972

Comments

bcoe commented Feb 29, 2020 • edited

Wave 1: (Day 1)

Wave 2 (Day 1)

Wave 3 (Day 1)

Wave 4 (Day 1)

Wave 5: fair game

Wave 6: fair game once wave 5 is done

Wait for go ahead from @bcoe

Wait for go ahead from Sebastian and Firebase Team

feywind commented Feb 29, 2020

zamnuts commented Mar 3, 2020

bcoe commented Mar 3, 2020

bcoe commented Mar 3, 2020

JustinBeckwith commented Jun 24, 2020

bcoe commented Feb 29, 2020 •

edited