Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check to ensure BC breaking changes in rest descriptors are caught #6219

Open
bshaffer opened this issue May 12, 2023 · 0 comments
Open
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

This change in the Batch library was not caught by our Breaking Change detector because it's a configuration change rather than a PHP surface change.

I see two solutions to this:

  1. Make the GAPIC generator create a surface artifact for rest configuration. Removal of these surface changes would be caught by the breaking change detector. This is similar to what we have in the Connection classes, where each method is implemented in a Connection/Rest class. The downside to this is it would create a LOT of overhead and also require a significant amount of work/changes in the generator, which would result in a lot of churn.
  1. Write a "Configuration Breaking Change Detector" that runs alongside the existing "Surface Breaking Change Detector". This could be expanded to check breaking changes in any descriptor config files.
@bshaffer bshaffer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant