BetaAnalyticsDataClient is documented as deprecated

[cawa-93]

The BetaAnalyticsDataClient has {@inheritdoc} inline tag

google-cloud-php/AnalyticsData/src/V1beta/BetaAnalyticsDataClient.php

Lines 31 to 36 in 7e7440d

	/** {@inheritdoc} */
	class BetaAnalyticsDataClient extends BetaAnalyticsDataGapicClient
	{
	// This class is intentionally empty, and is intended to hold manual additions to
	// the generated {@see BetaAnalyticsDataGapicClient} class.
	}

And inherit its docs from BetaAnalyticsDataGapicClient. But BetaAnalyticsDataGapicClient marked as @deprecated

google-cloud-php/AnalyticsData/src/V1beta/Gapic/BetaAnalyticsDataGapicClient.php

Lines 94 to 99 in 7e7440d

	*
	* @deprecated Please use the new service client {@see \Google\Analytics\Data\V1beta\Client\BetaAnalyticsDataClient}.
	*/
	class BetaAnalyticsDataGapicClient
	{
	use GapicClientTrait;

This leads to a false-positive deprecation warning:

BetaAnalyticsDataClient is deprecated. 

Please use the new service client {@see \Google\Analytics\Data\V1beta\Client\BetaAnalyticsDataClient}

[cawa-93]

Same for AnalyticsAdminServiceClient

google-cloud-php/AnalyticsAdmin/src/V1beta/AnalyticsAdminServiceClient.php

Lines 31 to 36 in 7e7440d

	/** {@inheritdoc} */
	class AnalyticsAdminServiceClient extends AnalyticsAdminServiceGapicClient
	{
	// This class is intentionally empty, and is intended to hold manual additions to
	// the generated {@see AnalyticsAdminServiceGapicClient} class.
	}

google-cloud-php/AnalyticsAdmin/src/V1beta/Gapic/AnalyticsAdminServiceGapicClient.php

Lines 144 to 149 in 7e7440d

	*
	* @deprecated Please use the new service client {@see \Google\Analytics\Admin\V1beta\Client\AnalyticsAdminServiceClient}.
	*/
	class AnalyticsAdminServiceGapicClient
	{
	use GapicClientTrait;

[Hectorhammett]

Hey @cawa-93!

Thanks for letting us know, will take a look on this for a proper solution.

[bshaffer]

Discussed offline but to summarize, these are separate classes. Let me try to explain better:

• The class Google\Analytics\Data\V1beta\BetaAnalyticsDataClient is deprecated, and it extends Google\Analytics\Data\V1beta\Gapic\BetaAnalyticsDataClient. Both of these classes are deprecated, and they recommend using Google\Analytics\Data\V1beta\Client\BetaAnalyticsDataClient instead.
• The class Google\Analytics\Data\V1beta\Client\BetaAnalyticsDataClient is NOT deprecated (notice it includes an extra Client namespace), and is the one recommended for use.

This is the same for the other classes you've listed. Sorry for the confusion - we will be removing the deprecated classes soon.

That being said, the messaging could absolutely be more clear, and we will work to improve this.