Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.1 release contains files with no modification date #27

Closed
vienzo opened this issue Mar 8, 2018 · 6 comments
Closed

1.0.1 release contains files with no modification date #27

vienzo opened this issue Mar 8, 2018 · 6 comments
Assignees
Labels
in progress 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@vienzo
Copy link

vienzo commented Mar 8, 2018

Something seems to have changed in how you guys build npm module between versions 1.0.0 and 1.0.1. The following files in the latest release do not contain date modified attribute:

google-p12-pem/build/src/index.js.map
google-p12-pem/build/src/index.d.ts
google-p12-pem/build/src/index.js
google-p12-pem/build/src/bin/gp12-pem.js
google-p12-pem/build/src/bin/gp12-pem.js.map
google-p12-pem/build/src/bin/gp12-pem.d.ts
google-p12-pem/LICENSE
google-p12-pem/README.md

This is causing some scripts that rely on modification date to fail (e.g. aws cli packaging that does file diffing by modification date).

Downgrading to 1.0.0 solves this.

@ofrobots
Copy link
Contributor

ofrobots commented Mar 8, 2018

Thanks for reporting. That is strange! We'll look into the issue.

@ofrobots
Copy link
Contributor

ofrobots commented Mar 8, 2018

❯ curl -s https://registry.npmjs.org/google-p12-pem/-/google-p12-pem-1.0.1.tgz | tar tvf -
-rw-r--r--  0 0      0        1060 Dec 31  1969 package/package.json
-rw-r--r--  0 0      0        1076 Dec 31  1969 package/LICENSE
-rw-r--r--  0 0      0        1883 Dec 31  1969 package/README.md
-rw-r--r--  0 0      0          11 Dec 31  1969 package/build/src/bin/gp12-pem.d.ts
-rw-r--r--  0 0      0         476 Dec 31  1969 package/build/src/bin/gp12-pem.js
-rw-r--r--  0 0      0         638 Dec 31  1969 package/build/src/bin/gp12-pem.js.map
-rw-r--r--  0 0      0         409 Dec 31  1969 package/build/src/index.d.ts
-rw-r--r--  0 0      0        1372 Dec 31  1969 package/build/src/index.js
-rw-r--r--  0 0      0        1403 Dec 31  1969 package/build/src/index.js.map

Compared with 1.0.0:

❯ curl -s https://registry.npmjs.org/google-p12-pem/-/google-p12-pem-1.0.0.tgz | tar tvf -
-rw-r--r--  0 0      0         963 Nov  9 18:23 package/package.json
-rw-r--r--  0 0      0        1076 Oct 31 16:47 package/LICENSE
-rw-r--r--  0 0      0        1884 Nov  9 18:16 package/README.md
-rw-r--r--  0 0      0           0 Nov  9 18:24 package/build/src/bin/gp12-pem.d.ts
-rw-r--r--  0 0      0         476 Nov  9 18:24 package/build/src/bin/gp12-pem.js
-rw-r--r--  0 0      0         638 Nov  9 18:24 package/build/src/bin/gp12-pem.js.map
-rw-r--r--  0 0      0         409 Nov  9 18:24 package/build/src/index.d.ts
-rw-r--r--  0 0      0        1372 Nov  9 18:24 package/build/src/index.js
-rw-r--r--  0 0      0        1403 Nov  9 18:24 package/build/src/index.js.map

The dates are indeed weird with 1.0.1.

@ofrobots
Copy link
Contributor

ofrobots commented Mar 8, 2018

So, running npm pack produces a tarball similar to 1.0.1 – where the dates are missing. I am using npm@5.7.1. If I downgrade to npm@5.5.1, I see proper timestamps.

@ofrobots
Copy link
Contributor

ofrobots commented Mar 8, 2018

  • npm@5.5.1: good tarballs
  • npm@5.6.0: good tarballs
  • npm@5.7.0: missing date
  • npm@5.7.1: missing date.

Seems like this is a regression in npm@5.7.0.

@ofrobots
Copy link
Contributor

ofrobots commented Mar 9, 2018

npm/npm#19968

@ofrobots
Copy link
Contributor

ofrobots commented Mar 9, 2018

Fixed in https://github.com/google/google-p12-pem/releases/tag/v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants