feat: set Table.Schema for permanent external tables #1701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: bigquery
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shollyman
reviewed
Mar 10, 2022
|
|
||
| assertNotNull(createdTable); | ||
| assertEquals(DATASET, createdTable.getTableId().getDataset()); | ||
| assertEquals(tableName, createdTable.getTableId().getTable()); |
There was a problem hiding this comment.
It seems like the significant change here is where schema is set, but you're not really probing that with this test.
There was a problem hiding this comment.
without the code change the IT will fail.
shollyman
approved these changes
Mar 10, 2022
stephaniewang526
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
🤖 I have created a release *beep* *boop* --- ## [2.10.0](v2.9.4...v2.10.0) (2022-03-14) ### Features * set Table.Schema for permanent external tables ([#1701](#1701)) ([73e829b](73e829b)) ### Documentation * **sample:** Added AuthorizeDataset Sample ([#1909](#1909)) ([a7a196b](a7a196b)) * **samples:** fix undeleteTable sample IT failure ([#1912](#1912)) ([7802f16](7802f16)), closes [#1911](#1911) ### Dependencies * update dependency com.google.apis:google-api-services-bigquery to v2-rev20220307-1.32.1 ([#1921](#1921)) ([fcad209](fcad209)) * update dependency com.google.cloud:google-cloud-storage to v2.4.5 ([#1906](#1906)) ([d35d689](d35d689)) * update dependency com.google.cloud:native-image-support to v0.12.10 ([#1919](#1919)) ([a59ccf5](a59ccf5)) * update dependency com.google.cloud:native-image-support to v0.12.8 ([#1907](#1907)) ([fddf593](fddf593)) * update dependency com.google.cloud:native-image-support to v0.12.9 ([#1913](#1913)) ([830dd50](830dd50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion related to go/bq-external-table-schema