feat: add Dataset ACL support #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
|
Blocked by cl/421673680. Will update the generated client version once the CL is released. |
…ng>) based on pending discovery doc changes (cl/421673680)
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
shollyman
approved these changes
Feb 1, 2022
| @@ -119,6 +122,11 @@ public Type getType() { | |||
| abstract Access toPb(); | |||
|
|
|||
| static Entity fromPb(Access access) { | |||
| if (access.getDataset() != null) { | |||
| return new Dataset( | |||
There was a problem hiding this comment.
minor constructor surprise for me, until I realized we're dealing with an ACL.Dataset and not a Dataset. I suspect this is just local ambiguity; any other places where we need to consider the naming?
There was a problem hiding this comment.
Yeah I agree it's a little confusing so I renamed it to be more explicit: DatasetAclEntity.
| @@ -146,6 +154,64 @@ static Entity fromPb(Access access) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Class for a BigQuery Dataset entity. Objects of this class represent a dataset from a different | |||
There was a problem hiding this comment.
Maybe clarify this is a Dataset ACL entity, not a Dataset entity?
There was a problem hiding this comment.
Updated. Thanks!
stephaniewang526
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 2, 2022
🤖 I have created a release *beep* *boop* --- ## [2.8.0](v2.7.1...v2.8.0) (2022-02-02) ### Features * add Dataset ACL support ([#1763](#1763)) ([18a11e8](18a11e8)) ### Dependencies * update dependency com.google.apis:google-api-services-bigquery to v2-rev20220123-1.32.1 ([#1819](#1819)) ([82175f1](82175f1)) * update dependency com.google.cloud:google-cloud-bigtable to v2.5.2 ([#1821](#1821)) ([0fe0a78](0fe0a78)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/211633697