Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): fix CopyMultipleTables sample IT failure and improve a few other samples #1817

Conversation

stephaniewang526
Copy link
Contributor

Fixes issue: #1805

@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Feb 1, 2022
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 1, 2022
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one nit


private static void requireEnvVar(String varName) {
private static String requireEnvVar(String varName) {
String value = System.getenv(varName);
assertNotNull(
"Environment variable " + varName + " is required to perform these tests.",
System.getenv(varName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can replace with value

@stephaniewang526 stephaniewang526 merged commit e12122c into googleapis:main Feb 1, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 1, 2022
🤖 I have created a release *beep* *boop*
---


### [2.7.1](v2.7.0...v2.7.1) (2022-02-01)


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#1813](#1813)) ([f2cfc8b](f2cfc8b))


### Documentation

* **samples:** fix CopyMultipleTables sample IT failure and improve a few other samples ([#1817](#1817)) ([e12122c](e12122c))
* **samples:** fix GrantViewAccess sample IT failure ([#1816](#1816)) ([d48ae41](d48ae41))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants