Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): enable use of GEOGRAPHY query params #2158

Merged
merged 6 commits into from Jul 15, 2022

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Jul 7, 2022

This PR adds support for binding a geography value directly as a query parameter, without the indirection of converting a string type to a geography time in the query body.

Related internal issue: b/238336732

This PR only includes a unit test.  A quick scan didn't highlight an
existing integration that tests all param types.
@shollyman shollyman requested a review from prash-mi July 7, 2022 18:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jul 7, 2022
@shollyman shollyman marked this pull request as ready for review July 11, 2022 21:06
@shollyman shollyman requested a review from a team July 11, 2022 21:06
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@shollyman shollyman requested a review from a team as a code owner July 14, 2022 18:54
@shollyman shollyman merged commit b19ad76 into googleapis:main Jul 15, 2022
@shollyman shollyman deleted the param-types branch July 15, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants