Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add decimal target type #2166

Merged
merged 5 commits into from Jul 20, 2022
Merged

feat: Add decimal target type #2166

merged 5 commits into from Jul 20, 2022

Conversation

prash-mi
Copy link
Contributor

Adding getDecimalTargetTypes and getDecimalTargetTypes and modified related unit test cases.

Fixes internal issue b/234571438

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Jul 15, 2022
@prash-mi
Copy link
Contributor Author

Raised b/239372813

@prash-mi prash-mi marked this pull request as ready for review July 19, 2022 06:44
@prash-mi prash-mi requested a review from a team July 19, 2022 06:44
@prash-mi prash-mi requested a review from a team as a code owner July 19, 2022 06:44
@prash-mi prash-mi requested a review from Neenu1995 July 19, 2022 06:44
shollyman
shollyman approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this out!

@prash-mi prash-mi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 20, 2022
@prash-mi prash-mi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 20, 2022
@prash-mi prash-mi merged commit ebbd8f5 into googleapis:main Jul 20, 2022
@release-please release-please bot mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prash-mi @shollyman @yoshi-kokoro