Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add remote function options to routine metadata #2291

Merged
merged 8 commits into from Sep 26, 2022
Merged

feat: add remote function options to routine metadata #2291

merged 8 commits into from Sep 26, 2022

Conversation

Neenu1995
Copy link
Contributor

No description provided.

@Neenu1995 Neenu1995 requested a review from a team September 23, 2022 23:12
@Neenu1995 Neenu1995 requested a review from a team as a code owner September 23, 2022 23:12
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Sep 23, 2022
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Sep 23, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 23, 2022
@Neenu1995
Copy link
Contributor Author

@shollyman @alvarowolfx PTAL

alvarowolfx
alvarowolfx reviewed Sep 26, 2022
View reviewed changes
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITRemoteUDFTest.java Outdated
RoutineInfo routineInfo =
RoutineInfo.newBuilder(routineId)
.setRoutineType("SCALAR_FUNCTION")
.setBody("x * 3")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the body and language are not needed in the context of a remote function.

alvarowolfx
alvarowolfx approved these changes Sep 26, 2022
View reviewed changes
Copy link

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just made a minor comment

@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 26, 2022
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Sep 26, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit d30670e into main Sep 26, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the remote-udf branch September 26, 2022 22:34
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 26, 2022
@release-please release-please bot mentioned this pull request Sep 26, 2022
Merged
This was referenced Oct 11, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarowolfx alvarowolfx alvarowolfx approved these changes

@shollyman shollyman Awaiting requested review from shollyman

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Neenu1995 @alvarowolfx @yoshi-kokoro