Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add field in HivePartitioningOptions #2678

Merged
merged 4 commits into from May 4, 2023
Merged

feat: add field in HivePartitioningOptions #2678

merged 4 commits into from May 4, 2023

Conversation

davidrabinowitz
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ v] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ v] Ensure the tests and linter pass
  • [ v] Code coverage does not decrease (if any source code was changed)
  • [v ] Appropriate docs were updated (if necessary)

Fixes #2677 ☕️

@davidrabinowitz davidrabinowitz requested review from a team as code owners May 2, 2023 22:31
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/java-bigquery API. labels May 2, 2023
@Neenu1995
Copy link
Contributor

Please add IT tests also.

@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels May 4, 2023
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 4, 2023
@Neenu1995 Neenu1995 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 4, 2023
@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 4165e55 into googleapis:main May 4, 2023
17 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 4, 2023
@release-please release-please bot mentioned this pull request May 4, 2023
Merged
This was referenced May 23, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neenu1995 Neenu1995 Neenu1995 approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HivePartitioningOptions does not convert the fields field
3 participants
@davidrabinowitz @Neenu1995 @yoshi-kokoro