Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update samples snippet to write to BYTES instead of ARRAY<BYTES> #2876

Merged
merged 2 commits into from Sep 21, 2023

Conversation

forksumit
Copy link
Contributor

@forksumit forksumit commented Sep 13, 2023

Update samples snippet InsertingDataTypes.java

  • Change datatype for school column from REPEATED BYTES to BYTES
  • Convert byte array to base64 string when writing into BYTES column (school)

Fixes #2875 ☕️

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. labels Sep 13, 2023
@obada-ab obada-ab assigned obada-ab and unassigned minherz Sep 19, 2023
@obada-ab
Copy link
Member

LGTM, manually tested and after the change a correct base64 encoded string is being uploaded to BQ

@obada-ab obada-ab added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 20, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 20, 2023
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 20, 2023
@obada-ab obada-ab added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 21, 2023
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners September 21, 2023 08:53
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 21, 2023
@obada-ab obada-ab added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2023
@obada-ab obada-ab added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Sep 21, 2023
@obada-ab obada-ab merged commit 7e040e9 into googleapis:main Sep 21, 2023
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples snippet InsertingDataTypes.java is writing byte array to ARRAY<BYTES> instead of BYTES
4 participants