Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bigquery.create NullPointerException when job already exists #3035

Merged
merged 2 commits into from Dec 13, 2023

Conversation

Lumenol
Copy link
Contributor

@Lumenol Lumenol commented Dec 5, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #3034 ☕️

@Lumenol Lumenol requested a review from a team as a code owner December 5, 2023 10:49
@Lumenol Lumenol requested a review from mrfaizal December 5, 2023 10:49
Copy link

google-cla bot commented Dec 5, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/java-bigquery API. labels Dec 5, 2023
@Lumenol
Copy link
Contributor Author

Lumenol commented Dec 5, 2023

It seems that mvn com.coveo:fmt-maven-plugin:format has made significant changes to the files. I'm not used to contributing, so feel free to provide feedback if it doesn't suit your preferences.

@PhongChuong PhongChuong self-requested a review December 5, 2023 19:36
@PhongChuong PhongChuong changed the title 3034: Reproduce and propose fix Fix: bigquery.create NullPointerException when job already exists Dec 12, 2023
@PhongChuong
Copy link
Contributor

Thanks for contributing.
I've updated the PR comments to follow a more standard convention, I hope you don't mind.

@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 12, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 12, 2023
Copy link
Contributor

@PhongChuong PhongChuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing.

@PhongChuong PhongChuong added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 13, 2023
@Lumenol Lumenol requested a review from a team as a code owner December 13, 2023 15:27
@PhongChuong PhongChuong added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Dec 13, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 13, 2023
@PhongChuong PhongChuong merged commit 38191b1 into googleapis:main Dec 13, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/java-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery: Creating a job with an existing ID throws a NullPointerException
3 participants