From b1a0cba6cdcc2d2afaa4c84154d8357c98a37589 Mon Sep 17 00:00:00 2001 From: Prashant Mishra Date: Mon, 23 May 2022 11:21:38 +0530 Subject: [PATCH 1/2] Fix flaky testPositionalQueryParameters --- .../java/com/google/cloud/bigquery/it/ITBigQueryTest.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java index dcfa5265f..0f4582804 100644 --- a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java +++ b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java @@ -3438,7 +3438,13 @@ public void testPositionalQueryParameters() throws InterruptedException { assertEquals(QUERY_RESULT_SCHEMA_BIGNUMERIC, result.getSchema()); assertEquals(2, Iterables.size(result.getValues())); for (FieldValueList values : result.iterateAll()) { - assertEquals("1.40845209522E9", values.get(0).getValue()); + // https://github.com/googleapis/java-bigquery/issues/2056. String comparison of values, eg + // 1.40845209522E9 vs 1408452095.22 seems to be failing, so comparing the values as epoc + // (Long) instead + // Double.parseDouble("1.40845209522E9"). + assertEquals( + (long) Double.parseDouble("1.40845209522E9"), + (long) Double.parseDouble(values.get(0).getValue().toString())); assertEquals("stringValue", values.get(1).getValue()); assertEquals(false, values.get(2).getBooleanValue()); assertEquals("0.33333333333333333333333333333333333333", values.get(3).getValue()); From 5fd8e88e80e1adfb42e8de836e435848b71e2697 Mon Sep 17 00:00:00 2001 From: Prashant Mishra Date: Mon, 23 May 2022 11:23:44 +0530 Subject: [PATCH 2/2] lint --- .../test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java | 1 - 1 file changed, 1 deletion(-) diff --git a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java index 0f4582804..5b2b74ec0 100644 --- a/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java +++ b/google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/it/ITBigQueryTest.java @@ -3441,7 +3441,6 @@ public void testPositionalQueryParameters() throws InterruptedException { // https://github.com/googleapis/java-bigquery/issues/2056. String comparison of values, eg // 1.40845209522E9 vs 1408452095.22 seems to be failing, so comparing the values as epoc // (Long) instead - // Double.parseDouble("1.40845209522E9"). assertEquals( (long) Double.parseDouble("1.40845209522E9"), (long) Double.parseDouble(values.get(0).getValue().toString()));