Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix WriteToDefaultStream example code to close the client properly #2433

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

GaoleMeng
Copy link
Contributor

@GaoleMeng GaoleMeng commented Mar 7, 2024

Client being created has to be properly closed, otherwise during garbage
collection an error will be reported showing channel not shutdown

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Copy link

conventional-commit-lint-gcf bot commented Mar 7, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 7, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 7, 2024
@GaoleMeng GaoleMeng force-pushed the main branch 2 times, most recently from 7d2912b to ef89a67 Compare March 7, 2024 07:21
Client being created has to be properly closed, otherwise during garbage
collection an error will be reported showing channel not shutdown
properly
@GaoleMeng GaoleMeng changed the title [not reviewable] fix: fix WriteToDefaultStream example code to close the client properly fix: fix WriteToDefaultStream example code to close the client properly Mar 7, 2024
@GaoleMeng GaoleMeng changed the title fix: fix WriteToDefaultStream example code to close the client properly Fix WriteToDefaultStream example code to close the client properly Mar 7, 2024
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 7, 2024
@GaoleMeng GaoleMeng requested review from a team as code owners March 7, 2024 17:51
@GaoleMeng GaoleMeng requested a review from tswast March 7, 2024 17:51
@GaoleMeng GaoleMeng changed the title Fix WriteToDefaultStream example code to close the client properly fix: fix WriteToDefaultStream example code to close the client properly Mar 7, 2024
@GaoleMeng GaoleMeng merged commit d8a52f8 into googleapis:main Mar 7, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants