Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide the default stream name #2444

Merged
merged 1 commit into from
Mar 13, 2024
Merged

feat: provide the default stream name #2444

merged 1 commit into from
Mar 13, 2024

Conversation

tomrussello
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2443 ☕️

@tomrussello tomrussello requested a review from a team as a code owner March 9, 2024 00:52
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Mar 9, 2024
@yirutang
Copy link
Contributor

There are some lint error. please run:
mvn com.coveo:fmt-maven-plugin:format

@tomrussello tomrussello force-pushed the get-default-name-from-stream-writer branch from ee74230 to 4c08d91 Compare March 11, 2024 18:00
@tomrussello
Copy link
Contributor Author

done @yirutang

@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024
@yirutang yirutang merged commit fe9c3ae into googleapis:main Mar 13, 2024
19 checks passed
@release-please release-please bot mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yirutang yirutang yirutang approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995 Neenu1995 is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StreamWriter should provide the default stream to a client
3 participants
@tomrussello @yirutang @yoshi-kokoro