Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test/sanity check for google-cloud-bom #178

Open
elharo opened this issue Dec 6, 2019 · 1 comment
Open

Integration test/sanity check for google-cloud-bom #178

elharo opened this issue Dec 6, 2019 · 1 comment
Labels
priority: p4 type: process A process-related concern. May include testing, release, or the like.

Comments

@elharo
Copy link
Contributor

elharo commented Dec 6, 2019

google-cloud-bom 0.120.0 went out with three major problems caused by two different root causes:

googleapis/google-cloud-java#6996
https://github.com/googleapis/java-kms/issues/21

Then 0.120.1 went out with a fix for one but not the other two.

All three problems were caught by a test for libraries-bom but not until after these release shipped.

I think we need to prioritize an integration test of google-cloud-bom that verifies that everything in the BOM can be resolved and that runs before we publish a release, probably as part of our main test suite.

@elharo
Copy link
Contributor Author

elharo commented Dec 6, 2019

Worth noting: the test that identified both classes of problems was MaximumLinkageErrorsTest:

https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/boms/integration-tests/src/test/java/com/google/cloud/MaximumLinkageErrorsTest.java

It did not get as far as looking for linkage errors. It simply attempted to load the entire BOM and that process failed before it had built a classpath.

@chingor13 chingor13 transferred this issue from googleapis/google-cloud-java Jan 7, 2020
@chingor13 chingor13 added the type: process A process-related concern. May include testing, release, or the like. label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p4 type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

4 participants