Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libraries-release-data): add service name lookup from artifact id for gapic libraries, add apiary libraries and spring cloud gcp to release data table. #6437

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Feb 14, 2024

Changes in this pr:

  • Add script to infer artifact id to service name match from StubSettings. (closing fix(libraries-release-data): add script to infer artifact id to service name match from StubSettings. (WIP) #6390 in favor of this pr)
  • Add script to parse artifact id and service name for apiary libraries from discovery docs.
  • Manually add spring-cloud-gcp to tracked library list. Note that service name column is borrowed here for tool name. (this is to match tool release dates)
  • revamped fetch-library-data.sh to require less strict structure in the returned maven page, so it can be reused for apiary lists.
  • Other minor cleanups.

Match sample analysis:
From sampled services from 2023-01-01 to now,
Before this change 145/235 did not have a match, after this change 53/235 missing match.

future enhancements:
To infer gapic libraries artifact id and service name closer to source (from googleapis yaml/protos).

@burkedavison
Copy link
Contributor

after this change 53/235 missing match.

We might consider just creating a hardcoded mapping for the remaining, if we think we've covered all future releases with the current logic.

Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>
@zhumin8 zhumin8 merged commit 9491edf into main Feb 16, 2024
27 checks passed
@zhumin8 zhumin8 deleted the get-service-artifactid-match-apiary branch February 16, 2024 16:04
@release-please release-please bot mentioned this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants