This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
fix: make title and description of Condition Nullable #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenWhitehead
force-pushed
the
iam-policy-condition-fix
branch
from
d749b01
to
419a713
Compare
According to https://cloud.google.com/iam/docs/conditions-overview#syntax_overview both title and description are optional. Currently, AutoValue treats these fields as non-null which goes against the definition from the API. This change may be considered breaking by some criteria, however this class is annotated @BetaApi.
BenWhitehead
force-pushed
the
iam-policy-condition-fix
branch
from
419a713
to
44ce24a
Compare
BenWhitehead
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
meltsufin
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://cloud.google.com/iam/docs/conditions-overview#syntax_overview both title and description are optional.
Currently, AutoValue treats these fields as non-null which goes against the definition from the API.
This change may be considered breaking by some criteria, however this class is annotated @BetaApi.