Skip to content
This repository has been archived by the owner on Dec 3, 2023. It is now read-only.

feat: Support get CREDENTIAL_ENV_NAME from properties #782

Merged
merged 1 commit into from Nov 23, 2022

Conversation

tisonkun
Copy link
Contributor

This closes #781.

Signed-off-by: tison wander4096@gmail.com

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #781 ☕️

If you write sample code, please follow the samples format.

@tisonkun tisonkun requested a review from a team as a code owner March 30, 2022 05:50
@google-cla
Copy link

google-cla bot commented Mar 30, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@tisonkun tisonkun changed the title Support get CREDENTIAL_ENV_NAME from properties feat: Support get CREDENTIAL_ENV_NAME from properties Mar 30, 2022
This closes googleapis#781.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun
Copy link
Contributor Author

ping @Neenu1995 @meltsufin any updates?

@meltsufin
Copy link
Member

@tisonkun Which client library are you using?

@tisonkun
Copy link
Contributor Author

tisonkun commented Nov 23, 2022

@meltsufin it's the BigQuery client.

@Neenu1995 Neenu1995 closed this Nov 23, 2022
@Neenu1995 Neenu1995 reopened this Nov 23, 2022
@Neenu1995 Neenu1995 added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 23, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 23, 2022
@Neenu1995 Neenu1995 merged commit 2bb7d57 into googleapis:main Nov 23, 2022
@tisonkun tisonkun deleted the patch-1 branch November 23, 2022 16:55
@tisonkun
Copy link
Contributor Author

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support get CREDENTIAL_ENV_NAME from system properties
4 participants