feat: Apply Google style recommendations #1057
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative PR just to show losalex@, will add issue if it seems like a good idea.
Fixes #TODO
Things our formatter does to this codebase:
{ }
consistently afterif
statements. No one-liners-without-curlies allowed.e_name
->eName
)Label.ClusterName
->Label.CLUSTER_NAME
). This would be a breaking change if the enum were intended to be public. I thinkLabel
's not supposed to be (altho it isprotected
so it could be...). I had to change the clirr allowlist for this!.Resource
is definitely private tho. Update: reverted theLabel
change because it's potentially breaking, but kept theResource
change.lowerSnakeCaseOfSystemUnderTest_lowerSnakeCaseOfExpectedBehavior
import static com.google.cloud.logging.Logging.TailOption
).ResourceTypeEnvironmentGetterImpl
)