Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Modify batching implementation in java-logging #705

Closed
minherz opened this issue Oct 3, 2021 · 2 comments
Closed

feat: Modify batching implementation in java-logging #705

minherz opened this issue Oct 3, 2021 · 2 comments
Assignees
@losalex
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. logging-resilience priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@minherz
Copy link
Contributor

minherz commented Oct 3, 2021 •
edited

The Logging.write() interface aggregates multiple calls in batches in order to optimize a number of calls to entries.write Logging API. It happens only when Logging.getWriteSynchronicity() returns Synchronicity.ASYNC.
The current implementation of the batching logic is located in the gax repo and has few drawbacks that should be fixed.

This is an umbrella issue for all relevant FRs that modify the current batching implementation to provide the following features:

  • expose batch configuration at logging client level
  • review existing error handling strategies and extend them if needed
  • modify current error reporting implementation

More technical details can be found in internal document.
@minherz minherz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. lang: java Issues specific to Java. labels Oct 3, 2021
@minherz minherz self-assigned this Oct 3, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Oct 3, 2021
@minherz minherz mentioned this issue Oct 3, 2021
Closed
@minherz minherz changed the title feat: Migrate batching logic from gapic to java-logging feat: Modify batching implementation in java-logging Nov 1, 2021
@minherz
Copy link
Contributor Author

minherz commented Nov 1, 2021

Exposing batch configuration feature googleapis/gax-java#730

@minherz
Copy link
Contributor Author

minherz commented Nov 1, 2021

Changing error reporting mechanism in gax-batching feature googleapis/sdk-platform-java#1317

@minherz minherz assigned losalex and unassigned minherz Feb 10, 2022
@arbrown arbrown added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jul 12, 2022
@losalex losalex mentioned this issue Oct 27, 2022
Merged
@losalex losalex closed this as completed Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. logging-resilience priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arbrown @minherz @losalex