From 8782533204fcc312c1063763f5073db83c72382f Mon Sep 17 00:00:00 2001 From: Mike Micatka <31972785+mmicatka@users.noreply.github.com> Date: Mon, 1 Aug 2022 17:23:07 -0400 Subject: [PATCH] fix: Updated log level from WARNING -> INFO for EOD failures (#1218) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * fix: Updated log level from WARNING -> INFO for EOD failures * formatting * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot --- README.md | 4 ++-- .../cloud/pubsub/v1/StreamingSubscriberConnection.java | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 9ad4cbe33..e98ba1a5f 100644 --- a/README.md +++ b/README.md @@ -58,13 +58,13 @@ implementation 'com.google.cloud:google-cloud-pubsub' If you are using Gradle without BOM, add this to your dependencies: ```Groovy -implementation 'com.google.cloud:google-cloud-pubsub:1.120.5' +implementation 'com.google.cloud:google-cloud-pubsub:1.120.6' ``` If you are using SBT, add this to your dependencies: ```Scala -libraryDependencies += "com.google.cloud" % "google-cloud-pubsub" % "1.120.5" +libraryDependencies += "com.google.cloud" % "google-cloud-pubsub" % "1.120.6" ``` ## Authentication diff --git a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java index 1067fa7e5..e7046c1be 100644 --- a/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java +++ b/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StreamingSubscriberConnection.java @@ -547,18 +547,17 @@ public void onFailure(Throwable t) { String errorMessage = metadataMap.get(ackId); if (errorMessage.startsWith(TRANSIENT_FAILURE_METADATA_PREFIX)) { // Retry all "TRANSIENT_*" error messages - do not set message future - logger.log(Level.WARNING, "Transient error message, will resend", errorMessage); + logger.log(Level.INFO, "Transient error message, will resend", errorMessage); ackRequestDataArrayRetryList.add(ackRequestData); } else if (errorMessage.equals(PERMANENT_FAILURE_INVALID_ACK_ID_METADATA)) { // Permanent failure, send logger.log( - Level.WARNING, + Level.INFO, "Permanent error invalid ack id message, will not resend", errorMessage); ackRequestData.setResponse(AckResponse.INVALID, setResponseOnSuccess); } else { - logger.log( - Level.WARNING, "Unknown error message, will not resend", errorMessage); + logger.log(Level.INFO, "Unknown error message, will not resend", errorMessage); ackRequestData.setResponse(AckResponse.OTHER, setResponseOnSuccess); } } else {