Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: exactly once support v3 #1022

Merged
merged 89 commits into from Mar 4, 2022
Merged

feat: exactly once support v3 #1022

merged 89 commits into from Mar 4, 2022

Conversation

mmicatka
Copy link
Contributor

@mmicatka mmicatka commented Feb 18, 2022 •
edited

  • Added new interfaces
    • AckReplyConsumerWithResponse
    • MessageReceiverWithAckResponse
  • Added AckResponse enum
  • Changed MessageDispatcher and StreamingSubscriberConnection to use builder pattern
  • Keeps track of whether exactly-once delivery is enabled for a subscription by looking at the subscription's SubscriptionProperties
  • Set the minimum ack deadline to 60 secs if exactly-once is known to be turned on.
  • Add new min-lease-extension parameter. If the user sets this, it overrides the auto-set param
  • Changed AckId information for Modacks and Acks to use a new AckRequestData object that also includes the message future (if applicable)

Minor Updates:

  • Added Mockito dependency for mocking in unit tests

gcf-owl-bot bot and others added 30 commits February 4, 2022 17:51
@gcf-owl-bot
feat: add exactly once delivery flag
439ae44 
PiperOrigin-RevId: 426415626

Source-Link: googleapis/googleapis@1f707ab

Source-Link: googleapis/googleapis-gen@2baebc5
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMmJhZWJjNTc5ZWQ0MmM0ZDE3ODgzYTE0ZWNhNjQ0MTFmNjlkY2M4NyJ9
@gcf-owl-bot
🦉 Updates from OwlBot
b03e3e8 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@gcf-owl-bot @mmicatka
chore: enable auto release in java (#1349) (#997)
bd0aed0 
* chore: fix auto-release

* chore: remove codecov.yml

* chore: update license headers for yaml files
Source-Link: googleapis/synthtool@5b77727
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ebc2104854c5b81c6fd72ca79400a2e20e0d510c5e0654fd1a19e5c9be160ca6
@gcf-owl-bot @mmicatka
chore: update auto-release script to fix breaking changes in v5 (#1350)…
02f3da7 
… (#998)

Source-Link: googleapis/synthtool@53a58c2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:3c950ed12391ebaffd1ee66d0374766a1c50144ebe6a7a0042300b2e6bb5856b
@renovate-bot @mmicatka
build(deps): update dependency com.google.cloud:google-cloud-shared-c…
7bf2598 
…onfig to v1.2.7 (#999)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.2.6` -> `1.2.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.7/compatibility-slim/1.2.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.7/confidence-slim/1.2.6)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-shared-config</summary>

### [`v1.2.7`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#&#8203;127-httpsgithubcomgoogleapisjava-shared-configcomparev126v127-2022-02-04)

[Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.6...v1.2.7)

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).
@renovate-bot @mmicatka
build(deps): update dependency org.apache.maven.plugins:maven-project…
faec051 
…-info-reports-plugin to v3.2.1 (#996)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.1.2` -> `3.2.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.2.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.2.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.2.1/compatibility-slim/3.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.2.1/confidence-slim/3.1.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).
@renovate-bot @mmicatka
chore(deps): update dependency com.google.cloud:libraries-bom to v24.…
62a6081 
…3.0 (#1001)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `24.2.0` -> `24.3.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/compatibility-slim/24.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/confidence-slim/24.2.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).
@renovate-bot @mmicatka
deps: update dependency com.google.cloud:google-cloud-core to v2.5.0 (#…
4c317ae 
…995)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.4.0` -> `2.5.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.0/compatibility-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.0/confidence-slim/2.4.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-core</summary>

### [`v2.5.0`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;250-httpsgithubcomgoogleapisjava-corecomparev240v250-2022-02-02)

[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.4.0...v2.5.0)

##### Features

-   add limit support to ReadChannel ([#&#8203;688](https://togithub.com/googleapis/java-core/issues/688)) ([476109e](https://togithub.com/googleapis/java-core/commit/476109e1943c1a9561cc636ffc64ab8cdd1888f9))

##### Bug Fixes

-   **java:** Initialize AsyncSSLPrivateKeyMethod (a grpc netty class) at run-time ([#&#8203;702](https://togithub.com/googleapis/java-core/issues/702)) ([24146a3](https://togithub.com/googleapis/java-core/commit/24146a35a10ae06238de9556c24dab5dbd3bcaff))

##### Dependencies

-   update dependency com.google.api:gax-bom to v2.12.0 ([#&#8203;698](https://togithub.com/googleapis/java-core/issues/698)) ([c10aab8](https://togithub.com/googleapis/java-core/commit/c10aab8a57ff0aad07a700540085e2ed7521b1a1))
-   update dependency com.google.protobuf:protobuf-bom to v3.19.4 ([#&#8203;699](https://togithub.com/googleapis/java-core/issues/699)) ([5d163f5](https://togithub.com/googleapis/java-core/commit/5d163f591547cd8e0e508b9c824a17da2074b264))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).
@release-please @mmicatka
chore(main): release 1.115.3 (#1002)
4391501 
🤖 I have created a release *beep* *boop*
---


### [1.115.3](v1.115.2...v1.115.3) (2022-02-08)


### Dependencies

* update dependency com.google.cloud:google-cloud-core to v2.5.0 ([#995](#995)) ([3b3b90a](3b3b90a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please @mmicatka
chore(main): release 1.115.4-SNAPSHOT (#1003)
3e28da2 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@mmicatka
Merge branch 'upstream_exactly_once_proto_changes' into exactly_once_…
3a99fb8 
…support_v3
@mmicatka
pulling in work from other branch
ff95cc9
@mmicatka
forgot a file
4c9d656
@mmicatka
wip
bf2dc68
@mmicatka
wip
7ea3430
@mmicatka
fixed a misssing flow controller
69b6c55
@mmicatka
typo
0634281
@mmicatka
working on integration tests
955a845
@mmicatka
wip
5e0b040
@mmicatka
wip
bef2023
@mmicatka
wip
27e27a9
@mmicatka
wip
60546fd
@mmicatka
wip
e4a1af7
@mmicatka
possibly partially working
5fb59c1
@mmicatka
I think it's working?
e3c5efb
@mmicatka
should work. need to add tests
b7424a5
@mmicatka
wip, cleaning things up
12a3a48
@mmicatka
wip
371d220
@mmicatka
wip
91f5580
@mmicatka
owlbot changes
bb59dd1
@hannahrogers-google hannahrogers-google added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2022
@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 4, 2022
@hannahrogers-google hannahrogers-google added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 4, 2022
@mmicatka mmicatka added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 4, 2022
@mmicatka mmicatka merged commit 02ed621 into googleapis:main Mar 4, 2022
@release-please release-please bot mentioned this pull request Mar 4, 2022
Merged
@anguillanneuf anguillanneuf mentioned this pull request Mar 8, 2022
Closed
@mmicatka mmicatka deleted the exactly_once_support_v3 branch March 10, 2022 18:45
@labianchin labianchin mentioned this pull request Jul 22, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf left review comments

@maheshgattani maheshgattani maheshgattani approved these changes

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Assignees

@maheshgattani maheshgattani

@hannahrogers-google hannahrogers-google

Labels
api: pubsub Issues related to the googleapis/java-pubsub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmicatka @maheshgattani @anguillanneuf @hannahrogers-google @renovate-bot