Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Removed EnableExactlyOnceDelivery from Builders #1052

Merged
merged 4 commits into from Mar 9, 2022
Merged

Fix: Removed EnableExactlyOnceDelivery from Builders #1052

merged 4 commits into from Mar 9, 2022

Conversation

mmicatka
Copy link
Contributor

@mmicatka mmicatka commented Mar 9, 2022 •
edited

Removing EnableExactlyOnceDelivery from Subscriber builder + constructor, StreamingSubscriberConnection builder + constructor, and MessageDispatcher builder + constructor.

EnableExactlyOnceDelivery defaults to false, and is pulled from the streaming pull response in StreamingSubscriberConnection.StreamingPullResponseObserver.onResponse and is propagated to StreamingSubscriberConnection and MessageDispatcher.

Also added comments to the AckReplyConsumerWithResponse to be in line with AckReplyConsumer.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Mar 9, 2022
@mmicatka mmicatka marked this pull request as ready for review March 9, 2022 15:57
@mmicatka mmicatka requested a review from a team as a code owner March 9, 2022 15:57
@mmicatka mmicatka changed the title Removed EnableExactlyOnceDelivery from Builders Fix: Removed EnableExactlyOnceDelivery from Builders Mar 9, 2022
@mmicatka mmicatka requested a review from a team as a code owner March 9, 2022 18:42
@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 9, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 9, 2022
@mmicatka mmicatka merged commit 9add538 into googleapis:main Mar 9, 2022
@release-please release-please bot mentioned this pull request Mar 9, 2022
Merged
@mmicatka mmicatka deleted the exactly_once_fixes branch March 10, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshgattani maheshgattani maheshgattani approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmicatka @maheshgattani