fix: adding a maximum metadata size when creating the subscriber #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: pubsub
mmicatka
force-pushed
the
increase_max_metadata_size_limit
branch
from
e2c29ce
to
faf11c4
Compare
hannahrogers-google
approved these changes
Mar 22, 2022
mmicatka
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a risk of crashing due to large metadata components of grpc responses when exactly once delivery is enabled. The metadata contains the ack-ids with responses statuses to indicate ack failures. The metadata size is set on the server-side to be a max of 4 MB which should be reflected on the client-side.