Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Too many leases #1135

Merged
merged 3 commits into from May 18, 2022
Merged

fix: Too many leases #1135

merged 3 commits into from May 18, 2022

Conversation

mmicatka
Copy link
Contributor

@mmicatka mmicatka commented May 17, 2022 •
edited

  • Moved the ackIdsInRequest for modack operations to the correct place.
  • Wrote tests around expected batching/partition behavior to verify change works as expected

Fixes #1126 which was due to incorrect partitioning of ackIds for ModifyAckDeadlineRequest

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/java-pubsub API. labels May 17, 2022
@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 17, 2022
@mmicatka mmicatka marked this pull request as ready for review May 17, 2022 21:02
@mmicatka mmicatka requested a review from a team as a code owner May 17, 2022 21:02
@mmicatka mmicatka merged commit c9bcec5 into googleapis:main May 18, 2022
@release-please release-please bot mentioned this pull request May 18, 2022
Merged
@mmicatka mmicatka mentioned this pull request May 26, 2022
Closed
@mmicatka mmicatka deleted the too_many_leases branch July 29, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahrogers-google hannahrogers-google hannahrogers-google approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PubSub Subscriber throws StatusRuntimeException when holding many leases
2 participants
@mmicatka @hannahrogers-google