Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid PubSubMessage leak on MessageDispatcher#processOutstandingMessage, fixes #1196 #1197

Merged
merged 1 commit into from Jul 25, 2022

Conversation

labianchin
Copy link
Contributor

@labianchin labianchin commented Jul 22, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1196 ☕️

If you write sample code, please follow the samples format.


This is a way we found to fix #1196 . Opening the PR here to gather feedback. We are open to other ways to fix the issue.

@labianchin labianchin requested a review from a team as a code owner July 22, 2022 09:43
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 22, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 22, 2022
@google-cla
Copy link

google-cla bot commented Jul 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Jul 22, 2022
@labianchin labianchin closed this Jul 22, 2022
@labianchin labianchin reopened this Jul 22, 2022
@mmicatka mmicatka added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 22, 2022
Copy link
Contributor

@mmicatka mmicatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will merge in after pipeline passes.

@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 25, 2022
@mmicatka mmicatka merged commit 1b8c440 into googleapis:main Jul 25, 2022
@labianchin labianchin deleted the fixPubSubMessageLeak branch July 27, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PubSubMessage memory leak on MessageDispatcher#processOutstandingMessage
3 participants