Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updating return types of ack/nack futures to be consistent with publish #1204

Merged
merged 4 commits into from Jul 29, 2022
Merged

fix: updating return types of ack/nack futures to be consistent with publish #1204

merged 4 commits into from Jul 29, 2022

Conversation

mmicatka
Copy link
Contributor

@mmicatka mmicatka commented Jul 29, 2022 •
edited

Updating the return types of the AckReplyConsumerWithResponse interface, as well as the implementation AckReplyConsumerWithResponseImpl, from Future to ApiFuture, in order to be consistent with the return type of Publish.publish.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jul 29, 2022
@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2022
@mmicatka mmicatka added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 29, 2022
@mmicatka mmicatka marked this pull request as ready for review July 29, 2022 18:13
@mmicatka mmicatka requested review from a team as code owners July 29, 2022 18:13
@mmicatka mmicatka merged commit 6e73ab9 into googleapis:main Jul 29, 2022
@release-please release-please bot mentioned this pull request Jul 29, 2022
Merged
@mmicatka mmicatka deleted the update_interface branch October 4, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamalaboulhosn kamalaboulhosn kamalaboulhosn approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmicatka @kamalaboulhosn