Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONTRIBUTING.md] Add link to Conventional Commits #1506

Closed
SimonScholz opened this issue Feb 25, 2023 · 1 comment
Closed

[CONTRIBUTING.md] Add link to Conventional Commits #1506

SimonScholz opened this issue Feb 25, 2023 · 1 comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@SimonScholz
Copy link

SimonScholz commented Feb 25, 2023 •
edited

I just created the following PR (#1505), after reading through your CONTRIBUTING.md.
Then on of the checks of the PR pointed me at the fact that my commit message is not using the Conventional Commits guidelines.
To inform contributors about this in advance it would be helpful to add a link to Conventional Commits.

The change of the CONTRIBUTING.md file can be found here: #1507
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Feb 25, 2023
@SimonScholz SimonScholz mentioned this issue Feb 25, 2023
Closed
4 tasks
@maitrimangal maitrimangal mentioned this issue Jun 12, 2023
Closed
4 tasks
@maitrimangal maitrimangal added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 12, 2023
@maitrimangal
Copy link
Member

hm, unfortunately it seems like this contributing doc is also autogenerated, and seems to be getting reversed by the post processor. Confirmed internally, and seems like in order to change this we would be changing all the CONTRIBUTING.md docs in the repo for googleapis org.

@maitrimangal maitrimangal closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
2 participants
@SimonScholz @maitrimangal