Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing the shutdown logic for streaming subscriber connection #1613

Merged
merged 3 commits into from Jun 20, 2023

Conversation

maitrimangal
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1544

If you write sample code, please follow the samples format.

@maitrimangal maitrimangal requested a review from a team as a code owner June 13, 2023 19:50
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Jun 13, 2023
@maitrimangal maitrimangal added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 13, 2023
Copy link
Contributor

@hannahrogers-google hannahrogers-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can do this. In runShutdown(), we call ackOperationsWaiter.waitComplete(). Which waits for all outstanding acks to be sent on the stub. If we close the stub before calling runShutdown, all remaining acks will all fail with the CancelledException.

Nevermind - I was thinking it was the stub we were shutting down. Shutting down the clientStream should be ok

@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 14, 2023
@maitrimangal maitrimangal added the owlbot:ignore instruct owl-bot to ignore a PR label Jun 15, 2023
@hannahrogers-google hannahrogers-google added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Jun 20, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner June 20, 2023 17:27
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jun 20, 2023
@maitrimangal maitrimangal merged commit 09aff9c into googleapis:main Jun 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shutdown order seems to be backwards
3 participants