New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: concurrent modification of processing receievd messages #1807
Merged
maitrimangal
merged 6 commits into
googleapis:main
from
maitrimangal:concurrentIssueExactlyOnce
Nov 6, 2023
Merged
fix: concurrent modification of processing receievd messages #1807
maitrimangal
merged 6 commits into
googleapis:main
from
maitrimangal:concurrentIssueExactlyOnce
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
Pull request size is extra small.
api: pubsub
Issues related to the googleapis/java-pubsub API.
labels
Oct 31, 2023
maitrimangal
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
kokoro:run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Oct 31, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 31, 2023
yoshi-kokoro
removed
kokoro:run
Add this label to force Kokoro to re-run the tests.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Oct 31, 2023
I expect the synchronized methods are going to make parallel processing much slower and so we should probably remove that and replace it with a concurrent data structure so move the concurrency control to a lower level. It looks like the pendingAcks, pendingNacks, and pendingReceipts do this. We can hopefully then get rid of the synchronized keyword on |
maitrimangal
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 31, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Oct 31, 2023
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: xs
Pull request size is extra small.
labels
Oct 31, 2023
product-auto-label
bot
added
size: xs
Pull request size is extra small.
and removed
size: s
Pull request size is small.
labels
Nov 2, 2023
maitrimangal
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 2, 2023
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Nov 2, 2023
kamalaboulhosn
approved these changes
Nov 6, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/java-pubsub API.
size: xs
Pull request size is extra small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lot of messages are published, then there is a concurrent modification issue in subscriber callbacks for exactly once. This PR makes the outstandingReciepts a concurrentHashMap, and thus allowing us to remove the synchronized keyword from notifyAckSuccess, and fail because all other data structures in this function are concurrent.
I have tested this as described in the following issue, and am unable to see the modification errors.
Fixes #1778