Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatabaseMetaData returns the Cloud Spanner type names, even when used for a PostgreSQL database #925

Open
olavloite opened this issue Aug 5, 2022 · 0 comments
Open

DatabaseMetaData returns the Cloud Spanner type names, even when used for a PostgreSQL database #925

olavloite opened this issue Aug 5, 2022 · 0 comments
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@olavloite
Copy link
Collaborator

The DatabaseMetaData#getTypes() method returns the Cloud Spanner type names when it is used with a database with PostgreSQL dialect. This means that there is a discrepancy between the data types that the database actually supports, and what the driver reports. E.g. the driver returns type timestamp, which should be timestamptz for PostgreSQL.

The method that needs to be updated is:

java-spanner-jdbc/src/main/java/com/google/cloud/spanner/jdbc/JdbcDatabaseMetaData.java

Line 920 in 9d6d313

public ResultSet getTypeInfo() {

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner-jdbc API. label Aug 5, 2022
@olavloite olavloite added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: spanner Issues related to the googleapis/java-spanner-jdbc API. and removed api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Aug 5, 2022
@olavloite olavloite assigned olavloite and unassigned rajatbhatta Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner-jdbc API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olavloite @rajatbhatta