docs(sample): relocate native image sample from old repo #1758

mpeddada1 · 2022-03-18T20:35:42Z

Relocating Spanner sample from GoogleCloudPlatform/native-image-support-java.
This PR also adds an integration test that can be run as a native image.

Calling mvn package -Pnative -DskipTests builds the native image for the application and calling mvn test -Pnative runs the test as a native image.

For more information: https://graalvm.github.io/native-build-tools/latest/maven-plugin.html#configuration.

cc @ansh0l @meltsufin

generated-files-bot · 2022-03-18T20:35:47Z

Warning: This pull request is touching the following templated files:

samples/pom.xml

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

ansh0l

LGTM.

Minor nit: I think since the parent folder is named samples, we should call this one as native-image instead of native-image-sample

…er into move-native-sample

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mpeddada1 · 2022-04-26T19:10:42Z

Thank you @ansh0l! I've renamed this to native-image

…ative-sample

…er into move-native-sample

ansh0l · 2022-05-23T07:47:02Z

Closing since native image changes have been released with #1878

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

…er into move-native-sample

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mpeddada1 · 2022-06-01T17:00:43Z

Rerunning because com.google.cloud.spanner.it.ITInstanceAdminTest is being flaky.

mpeddada1 · 2022-06-01T17:25:48Z

All checks are now green.

ansh0l

At a quick glance, looks alright. Please take a full review with @rajatbhatta

ansh0l · 2022-06-01T17:51:48Z

samples/native-image/pom.xml

+      <dependency>
+        <groupId>com.google.cloud</groupId>
+        <artifactId>libraries-bom</artifactId>
+        <version>25.2.0</version>


QQ> AFAIK, currently, we get automated PRs for cloud bom version bumps. Would now there be 2 such PRs (one for regular samples/pom.xml, another for samples/native-image/pom.xml), or would both end up coming into 1 PR?

It would all be updated in a single PR. Here is an example: googleapis/java-pubsub#1132

samples/native-image/README.md

Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>

rajatbhatta

LGTM.

@rajatbhatta

The requested changes have been addressed so modifying this to a request comment after receiving an approval from @rajatbhatta

mpeddada1 · 2022-06-02T14:44:43Z

Thank you both for the review!

🤖 I have created a release *beep* *boop* --- ## [6.25.6](v6.25.5...v6.25.6) (2022-06-22) ### Bug Fixes * PostgreSQL parser should not treat \ as an escape char ([#1921](#1921)) ([260bbe3](260bbe3)), closes [#1920](#1920) ### Documentation * **sample:** relocate native image sample from old repo ([#1758](#1758)) ([ef187f4](ef187f4)) ### Dependencies * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#1907](#1907)) ([01f8a07](01f8a07)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1918](#1918)) ([be8b50b](be8b50b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

docs(sample): relocate native image sample from old repo

60c6463

mpeddada1 requested review from a team as code owners March 18, 2022 20:35

product-auto-label bot added api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Mar 18, 2022

blunderbuss-gcf bot assigned anguillanneuf Mar 18, 2022

mpeddada1 requested review from suztomo, Neenu1995 and meltsufin March 18, 2022 20:36

🦉 Updates from OwlBot post-processor

0334450

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mpeddada1 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 22, 2022

ansh0l approved these changes Mar 29, 2022

View reviewed changes

ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 29, 2022

mpeddada1 added 2 commits April 26, 2022 15:06

rename to native-image

a39d1ba

Merge branch 'move-native-sample' of github.com:googleapis/java-spann…

c021590

…er into move-native-sample

product-auto-label bot added the size: l Pull request size is large. label Apr 26, 2022

gcf-owl-bot bot and others added 2 commits April 26, 2022 19:09

🦉 Updates from OwlBot post-processor

444817d

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'main' into move-native-sample

1233993

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2022

mpeddada1 added 3 commits April 27, 2022 15:38

Merge branch 'main' of github.com:googleapis/java-spanner into move-n…

0125710

…ative-sample

upgrade libraries bom and remove unused dependency

7a1ac24

Merge branch 'move-native-sample' of github.com:googleapis/java-spann…

2e9145c

…er into move-native-sample

ansh0l closed this May 23, 2022

mpeddada1 reopened this May 25, 2022

🦉 Updates from OwlBot post-processor

d886761

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022

mpeddada1 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 1, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022

mpeddada1 and others added 3 commits June 1, 2022 11:28

update readme to use 22.1.0

f85fe43

Merge branch 'move-native-sample' of github.com:googleapis/java-spann…

a04b801

…er into move-native-sample

🦉 Updates from OwlBot post-processor

f640fb7

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2022

ansh0l reviewed Jun 1, 2022

View reviewed changes

mpeddada1 requested a review from rajatbhatta June 2, 2022 11:08

rajatbhatta reviewed Jun 2, 2022

View reviewed changes

samples/native-image/README.md Outdated Show resolved Hide resolved

Update samples/native-image/README.md

97088f1

Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>

rajatbhatta approved these changes Jun 2, 2022

View reviewed changes

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2022

mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2022

mpeddada1 merged commit ef187f4 into main Jun 2, 2022

mpeddada1 deleted the move-native-sample branch June 2, 2022 14:44

release-please bot mentioned this pull request Jun 6, 2022

chore(main): release 6.25.6 #1911

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs(sample): relocate native image sample from old repo #1758

docs(sample): relocate native image sample from old repo #1758

mpeddada1 commented Mar 18, 2022 •

edited

generated-files-bot bot commented Mar 18, 2022

ansh0l left a comment

mpeddada1 commented Apr 26, 2022

ansh0l commented May 23, 2022

mpeddada1 commented Jun 1, 2022 •

edited

mpeddada1 commented Jun 1, 2022

ansh0l left a comment

ansh0l Jun 1, 2022

mpeddada1 Jun 1, 2022

rajatbhatta left a comment

mpeddada1 commented Jun 2, 2022

docs(sample): relocate native image sample from old repo #1758

docs(sample): relocate native image sample from old repo #1758

Conversation

mpeddada1 commented Mar 18, 2022 • edited

generated-files-bot bot commented Mar 18, 2022

ansh0l left a comment

Choose a reason for hiding this comment

mpeddada1 commented Apr 26, 2022

ansh0l commented May 23, 2022

mpeddada1 commented Jun 1, 2022 • edited

mpeddada1 commented Jun 1, 2022

ansh0l left a comment

Choose a reason for hiding this comment

ansh0l Jun 1, 2022

Choose a reason for hiding this comment

mpeddada1 Jun 1, 2022

Choose a reason for hiding this comment

rajatbhatta left a comment

Choose a reason for hiding this comment

mpeddada1 commented Jun 2, 2022

mpeddada1 commented Mar 18, 2022 •

edited

mpeddada1 commented Jun 1, 2022 •

edited