Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding new fields for Instance Create Time and Update Time #1913

Merged
merged 9 commits into from Jul 15, 2022
Merged

feat: Adding new fields for Instance Create Time and Update Time #1913

merged 9 commits into from Jul 15, 2022

Conversation

gauravpurohit06
Copy link
Contributor

No description provided.

@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner June 8, 2022 06:34
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jun 8, 2022
@ansh0l ansh0l requested a review from rajatbhatta June 13, 2022 05:44
rajatbhatta
rajatbhatta requested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a few changes. Please take a look.

google-cloud-spanner/src/test/java/com/google/cloud/spanner/InstanceInfoTest.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/InstanceInfo.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Instance.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Instance.java Outdated Show resolved Hide resolved
ansh0l
ansh0l requested changes Jul 4, 2022
View reviewed changes
Copy link
Member

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please

  1. merge the changes from autogenerated PR once the protos are merged into googleapis
  2. remove the autogenerated code from this PR
  3. raise a fresh PR with changes, link this PR on the new one, and close this one.

@gauravpurohit06 gauravpurohit06 changed the title feat: Adding new fields for Instance Create Time and Update Time [DO NOT MERGE] feat: Adding new fields for Instance Create Time and Update Time Jul 13, 2022
@gauravpurohit06
Copy link
Contributor Author

LGTM.

Please

  1. merge the changes from autogenerated PR once the protos are merged into googleapis
  2. remove the autogenerated code from this PR
  3. raise a fresh PR with changes, link this PR on the new one, and close this one.

PR doesn't include autogenerated protos, so we can go ahead with merging this PR.

ansh0l
ansh0l approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@rajatbhatta rajatbhatta added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 14, 2022
@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@suztomo
Copy link
Member

suztomo commented Jul 15, 2022

https://pantheon.corp.google.com/cloud-build/builds;region=global/02c62967-e31d-4696-9554-415d2a1a33b9?project=repo-automation-bots says:

Step #8: git push --no-verify
Step #8: To https://github.com/gauravpurohit06/java-spanner.git
Step #8:  ! [remote rejected] span_instance_additional_fields -> span_instance_additional_fields (permission denied)
Step #8: error: failed to push some refs to 'https://github.com/gauravpurohit06/java-spanner.git'

@gauravpurohit06 gauravpurohit06 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 15, 2022
@gauravpurohit06 gauravpurohit06 requested a review from a team as a code owner July 15, 2022 13:44
@gauravpurohit06 gauravpurohit06 merged commit 2c71e02 into googleapis:main Jul 15, 2022
@release-please release-please bot mentioned this pull request Jul 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite left review comments

@ansh0l ansh0l ansh0l approved these changes

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gauravpurohit06 @suztomo @olavloite @ansh0l @rajatbhatta