Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgreSQL Connection API wrongly identifies slash as an escape character in quoted literals and identifiers #1920

Closed
olavloite opened this issue Jun 22, 2022 · 0 comments · Fixed by #1921 or #1911
Closed

PostgreSQL Connection API wrongly identifies slash as an escape character in quoted literals and identifiers #1920

olavloite opened this issue Jun 22, 2022 · 0 comments · Fixed by #1921 or #1911
Assignees
@olavloite
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@olavloite
Copy link
Collaborator

The Connection API wrongly identifies a slash inside of a quoted literal or identifier as an escape character, which can lead to incorrect INVALID_ARGUMENT: SQL statement contains an unclosed literal errors.
@olavloite olavloite added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 22, 2022
@olavloite olavloite self-assigned this Jun 22, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jun 22, 2022
olavloite added a commit that referenced this issue Jun 22, 2022
@olavloite
fix: PostgreSQL parser should not treat \ as an escape char
571b0b4 
The PostgreSQL parser that removes comments and checks the type of
statement should not consider a backslash inside a quoted literal or
identifier as an escape character. Instead, only double occurrences of
the same quotes as the begin/end quote should be considered as an escape
inside a quoted literal or identifier.

Fixes #1920
@olavloite olavloite mentioned this issue Jun 22, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 22, 2022
@olavloite
fix: PostgreSQL parser should not treat \ as an escape char (#1921)
260bbe3 
The PostgreSQL parser that removes comments and checks the type of
statement should not consider a backslash inside a quoted literal or
identifier as an escape character. Instead, only double occurrences of
the same quotes as the begin/end quote should be considered as an escape
inside a quoted literal or identifier.

Fixes #1920
@release-please release-please bot mentioned this issue Jun 22, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 22, 2022
@release-please
chore(main): release 6.25.6 (#1911)
6c89b59 
🤖 I have created a release *beep* *boop*
---


## [6.25.6](v6.25.5...v6.25.6) (2022-06-22)


### Bug Fixes

* PostgreSQL parser should not treat \ as an escape char ([#1921](#1921)) ([260bbe3](260bbe3)), closes [#1920](#1920)


### Documentation

* **sample:** relocate native image sample from old repo ([#1758](#1758)) ([ef187f4](ef187f4))


### Dependencies

* update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.11 ([#1907](#1907)) ([01f8a07](01f8a07))
* update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#1918](#1918)) ([be8b50b](be8b50b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this issue Jan 22, 2024
@gcf-owl-bot
chore: Create renovate_config_check.yaml (#1920)
9d3d44a 
* chore: Create renovate_config_check.yaml
Source-Link: googleapis/synthtool@6612ab8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a6aa751984f1e905c3ae5a3aac78fc7b68210626ce91487dc7ff4f0a06f010cc
ddixit14 pushed a commit that referenced this issue Jan 22, 2024
@gcf-owl-bot
chore: Create renovate_config_check.yaml (#1920) (#2795)
8bf2a73 
* chore: Create renovate_config_check.yaml
Source-Link: googleapis/synthtool@6612ab8
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:a6aa751984f1e905c3ae5a3aac78fc7b68210626ce91487dc7ff4f0a06f010cc

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olavloite olavloite

Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@olavloite