Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: retry on RST_STREAM internal error #2111

Merged
merged 3 commits into from Jan 10, 2023
Merged

fix: retry on RST_STREAM internal error #2111

merged 3 commits into from Jan 10, 2023

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Oct 18, 2022 •
edited

The Spanner server can return an internal error closing the connection stream. When this happens an InternalException is thrown with a specific EOS message.

This case need to be retried for all the operations.

  • PDML
  • Mutations
  • ReadOnlyTransactions
  • ReadWriteTransactions

@rahul2393 rahul2393 requested a review from a team as a code owner October 18, 2022 06:15
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Oct 18, 2022
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2022
@rahul2393 @olavloite
Update google-cloud-spanner/src/test/java/com/google/cloud/spanner/Is…
c7344c0 
…RetryableInternalErrorTest.java

Co-authored-by: Knut Olav Løite <koloite@gmail.com>
@rahul2393 rahul2393 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 10, 2023 07:12
@rahul2393 rahul2393 merged commit d5372e6 into googleapis:main Jan 10, 2023
@release-please release-please bot mentioned this pull request Jan 10, 2023
Merged
@taka-oyama taka-oyama mentioned this pull request Jan 31, 2023
Closed
@bshaffer bshaffer mentioned this pull request Mar 3, 2023
Open
@vishwarajanand vishwarajanand mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@rajatbhatta rajatbhatta Awaiting requested review from rajatbhatta

@ansh0l ansh0l Awaiting requested review from ansh0l

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rahul2393 @olavloite @yoshi-kokoro